develooper Front page | perl.perl5.porters | Postings from July 2012

[perl #114118] TODO task, refactor t/op/die.t to use test.pl instead of making TAP by hand.

Thread Previous
From:
Father Chrysostomos via RT
Date:
July 12, 2012 23:11
Subject:
[perl #114118] TODO task, refactor t/op/die.t to use test.pl instead of making TAP by hand.
Message ID:
rt-3.6.HEAD-11172-1342159899-135.114118-15-0@perl.org
On Thu Jul 12 22:53:42 2012, colink@perldreamer.com wrote:
> I've been pretty confident about the other patches, but this particular 
> refactor could use a second set of eyes to make sure that all the 
> intricacies of the original have been maintained in the refactor.
> 
> For example, this test has fewer tests than the original; many of the 
> extra tests seemed to be incidental.

The first thing that pops out at me is the lack of a test count.

If there are tests inside __DIE__ handlers, there is a chance the
handler won’t be called, yet the tests will pass anyway.  A test count
will catch that.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: new
https://rt.perl.org:443/rt3/Ticket/Display.html?id=114118

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About