On Thu Jul 12 22:53:42 2012, colink@perldreamer.com wrote: > I've been pretty confident about the other patches, but this particular > refactor could use a second set of eyes to make sure that all the > intricacies of the original have been maintained in the refactor. > > For example, this test has fewer tests than the original; many of the > extra tests seemed to be incidental. The first thing that pops out at me is the lack of a test count. If there are tests inside __DIE__ handlers, there is a chance the handler won’t be called, yet the tests will pass anyway. A test count will catch that. -- Father Chrysostomos --- via perlbug: queue: perl5 status: new https://rt.perl.org:443/rt3/Ticket/Display.html?id=114118Thread Previous