On Thu, Jul 12, 2012 at 9:43 AM, Nicholas Clark <nick@ccl4.org> wrote: > > I looked at Maintainers.PL > > Things that seemed to crop up more than once in EXCLUDED were > > 1) bundled modules in inc/ or t/lib > 2) tests. I infer that the core would skip for some reason > 3) examples > 4) Makefile.PL and other build stuff the core doesn't need, or causes problems > > In the case of (2) and (4), the right solution might be to add skips for the > tests (and liase with upstream to get them in), and to figure out how to > refactor the Makefile.PL to behave suitably for the core, or how to get the > core to behave suitably for the Makefile.PL That might be a little tricky when the reason for #4 is the use of Module::Install, which looks in inc/ at compile time and tries to auto-upgrade itself if it's not the latest version. The check for "Am I in core?" would have to also be done at compile time and then prevent the compiler from seeing the C<use inc::Module::Install;> line or equivalent, and then also provide an alternative, traditional MakeMaker-based implementation. At which point simply generating the Makefile.PL like we do now seems preferable, and the remaining problem is how to know when to do that for a random tarball dropped in from CPAN.Thread Previous | Thread Next