develooper Front page | perl.perl5.porters | Postings from May 2012

[perl #9423] vec assignments generate 2 warnings, I'd prefer none

Thread Next
From:
Father Chrysostomos via RT
Date:
May 26, 2012 11:22
Subject:
[perl #9423] vec assignments generate 2 warnings, I'd prefer none
Message ID:
rt-3.6.HEAD-7788-1338056537-1162.9423-15-0@perl.org
On Fri May 25 18:49:56 2012, Hugmeir wrote:
> On Mon Jun 13 11:53:26 2011, chorny wrote:
> > Same 2 warnings for each line on perl 5.14.0.
> > 
> > http://rt.perl.org/rt3/Ticket/Display.html?id=9423
> > 
> 
> Same warnings in 5.16.0, albeit slightly more helpful, since they point
> at the uninit variable.
> Attached two two patches: the first one makes sv_pvn_force_flags guard
> against sv_2pv_flags returning NULL, which can happen if it's passed
> SV_UNDEF_RETURNS_NULL; The second patch silences the uninit warnings for
> vec() by using SV_UNDEF_RETURNS_NULL.
> 
> However, I make no judgment whenever silencing these is a good move; But
> if it isn't, this ticket should be rejected.

I agree that silencing the warning for lvalue vec makes sense, but it
should still warn for rvalue, I think.

I admit to having only skimmed your patch quickly.  Does it do that? 
This bit here suggests it does:

@@ -1032,10 +1032,8 @@ Use of uninitialized value $g2 in substr at - line 9.
 Use of uninitialized value $m1 in substr at - line 9.
 Use of uninitialized value $m2 in vec at - line 11.
 Use of uninitialized value $g1 in vec at - line 11.
-Use of uninitialized value $m1 in vec at - line 11.
 Use of uninitialized value $m2 in vec at - line 12.
 Use of uninitialized value $g1 in vec at - line 12.
-Use of uninitialized value $m1 in vec at - line 12.
 Use of uninitialized value $m1 in index at - line 14.
 Use of uninitialized value $m2 in index at - line 14.
 Use of uninitialized value $g1 in index at - line 15.



-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=9423

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About