develooper Front page | perl.perl5.porters | Postings from March 2012

incorrect git tags (was Re: Script to normalize the old perl- tags)

Thread Previous
From:
Nicholas Clark
Date:
March 31, 2012 02:48
Subject:
incorrect git tags (was Re: Script to normalize the old perl- tags)
Message ID:
20120331094810.GX18528@plum.flirble.org
tl;dr: Don't trust the git tags for pre-git releases to be accurate.
eg perl-5.8.6, perl-5.8.5, perl-5.8.4, perl-5.8.3
That list is not guaranteed to be complete

On Thu, Nov 03, 2011 at 04:28:16PM +0000, Nicholas Clark wrote:
> On Sat, Oct 22, 2011 at 11:07:32PM -0400, Jesse Vincent wrote:
> > 
> > 
> > Before anyone runs this on the main repository, talk to BooK. He did a
> > bunch of work to actually walk through all the tags.  IIRC, not all of
> > the perl- tags actually map to the right commits. I'd be sad if we
> > enshrined the wrong commits with v5.x tags.
> 
> Certainly, perl-5.10.0 didn't, as v5.10.0 is in the right place, whilst
> perl-5.10.0 was not.

OK, unrelated ticket investigation reveals that several other tags are
definitely a bit off. So (sadly) tags in the repository that predate git
shouldn't be trusted, until verified against a tarball.

My message for the commit for each maint-5.8 releases was generally
unimaginatively consistent:

$ git log -n1 perl-5.8.9
commit 0d3ff86caffb5db8118ca460a7c48b04bbef3128
Author: Nicholas Clark <nick@ccl4.org>
Date:   Sun Dec 14 18:26:38 2008 +0000

    Break a leg.
    
    p4raw-id: //depot/maint-5.8/perl@35095

$ git log -n1 perl-5.8.7
commit 3eef4faaf8d7fa185749184afd7dc737b8039f42
Author: Nicholas Clark <nick@ccl4.org>
Date:   Mon May 30 21:22:34 2005 +0000

    Break a leg
    
    p4raw-id: //depot/maint-5.8/perl@24641

$ git log -n1 perl-5.8.2
commit cd0a488b07b3463de32e3c5e1e640816ea3d0b9a
Author: Nicholas Clark <nick@ccl4.org>
Date:   Wed Nov 5 19:58:51 2003 +0000

    Break a leg.
    
    p4raw-id: //depot/maint-5.8/perl@21670



The commit that follows it is consistent - either of these two texts:


commit 958b695df30a463fba33742cb3f47f2c7858a200
Author: Nicholas Clark <nick@ccl4.org>
Date:   Sun Nov 28 00:09:35 2004 +0000

    Disarm the maint branch
    
    p4raw-id: //depot/maint-5.8/perl@23559


commit 6e9c4b1ac05ebfcfee0933b213303c6b22d13b16
Author: Nicholas Clark <nick@ccl4.org>
Date:   Wed Feb 1 18:22:12 2006 +0000

    That was 5.8.8.
    
    p4raw-id: //depot/maint-5.8/perl@27041


5.8.8 and 5.8.4 looks like an exceptions, in that they use the "That was"
message, and

5.8.8: I made 3 commits after the commit that removed the RC marker from
       patchelevel.h, and used 
5.8.4: Didn't "Break a leg":

commit 91a7d2edb06b2806ea64a649fca688b949a02258
Author: Nicholas Clark <nick@ccl4.org>
Date:   Wed Apr 21 19:37:51 2004 +0000

    Oink, oink, flap, flap!
    
    p4raw-id: //depot/maint-5.8/perl@22731

5.8.3 adds quite a few commits after tweaking patchlevel.h
The last is this rather innocuous:

* | | | | | commit 3bb43b7088d6f022d930aee1682a93abdbb0d590
| | | | | | Author: Nicholas Clark <nick@ccl4.org>
| | | | | | Date:   Wed Jan 14 17:55:17 2004 +0000
| | | | | | 
| | | | | |     Update Changes
| | | | | |     
| | | | | |     p4raw-id: //depot/maint-5.8/perl@22152
| | | | | |       

So, at least the tags perl-5.8.6, perl-5.8.5, perl-5.8.4, perl-5.8.3
do not correspond to the last commit before the tarball. :-(

Nicholas Clark

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About