develooper Front page | perl.perl5.porters | Postings from February 2012

Re: [perl #108780] overload::StrVal and qr//

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
February 16, 2012 08:15
Subject:
Re: [perl #108780] overload::StrVal and qr//
Message ID:
20120216161523.GF2998@iabyn.com
On Mon, Jan 30, 2012 at 09:54:28AM -0800, Father Chrysostomos via RT wrote:
> On Sun Jan 29 13:35:16 2012, davem wrote:
> > On Sun, Jan 29, 2012 at 01:03:52PM -0800, Father Chrysostomos via RT
> wrote:
> > > If I volunteer to write the new fix, do you mind if I apply my fix to
> > > blead now?  I’ll leave the PL_reginterp_cnt hack in sv_2pv for now and
> > > simply repeat it in pp_regcomp.  (Removing the hack from sv_2pv has
> > > enough implications to make my head spin.)
> > 
> > That's ok.
> 
> Here is a patch against the davem/re_eval branch.
> 
> You will have to rebase or cherry-pick 8d56929114 and a75c6ed6bbe8 to
> see the effect.

Thanks, now applied to my rebased branch.

>  		else {
> +		    if (SvROK(msv) && SvTYPE(SvRV(msv)) == SVt_REGEXP)
> +			msv = SvRV(msv);

I also included the
			PL_reginterp_cnt +=
			    RX_SEEN_EVALS((REGEXP *)MUTABLE_PTR(msv));

from your blead version, as I'm not ready to ditch PL_reginterp_cnt yet.

-- 
The Enterprise's efficient long-range scanners detect a temporal vortex
distortion in good time, allowing it to be safely avoided via a minor
course correction.
    -- Things That Never Happen in "Star Trek" #21

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About