develooper Front page | perl.perl5.porters | Postings from February 2012

[perl #108952] [PATCH] 97df921 fix PerlIO-scalar test when unpack J fails

Thread Previous | Thread Next
From:
Father Chrysostomos via RT
Date:
February 3, 2012 14:48
Subject:
[perl #108952] [PATCH] 97df921 fix PerlIO-scalar test when unpack J fails
Message ID:
rt-3.6.HEAD-14510-1328309309-1937.108952-15-0@perl.org
On Fri Feb 03 14:02:20 2012, ikegami@adaelis.com wrote:
> On Tue, Jan 24, 2012 at 4:01 PM, Father Chrysostomos via RT <
> perlbug-followup@perl.org> wrote:
> 
> > On Tue Jan 24 10:35:00 2012, ikegami@adaelis.com wrote:
> > > If you want more robust, I'd recommend:
> > >
> > > my $ptrlen = length(pack("P", "abc"));
> > > my $ptrfmt = $ptrlen == length(pack("J", 0)) ? "J"
> > >            : $ptrlen == length(pack("I", 0)) ? "I"
> > >            : die;
> >
> > OK, then I’ll leave it to you whether we should change it. :-)
> >
> 
> Attached. (Only the code that initialises $ptrfmt was changed. The rest of
> are indentation fixes.)
> 
> - Eric

Thank you.  Applied as 91087fe.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=108952

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About