Front page | perl.perl5.porters |
Postings from February 2012
Re: whither study()?
Thread Previous
|
Thread Next
From:
demerphq
Date:
February 1, 2012 01:03
Subject:
Re: whither study()?
Message ID:
CANgJU+Wnn2xPjQWwA_sWNtxzrQzSgOg3KLmm6L3PycPji14hwA@mail.gmail.com
On 1 February 2012 06:27, Abhijit Menon-Sen <ams@toroid.org> wrote:
> At 2012-01-31 22:18:25 -0500, perl.p5p@rjbs.manxome.org wrote:
>>
>> Can we do this, as Nick suggested (with as little code-touching as
>> possible) immediately?
>
> As it happens, I was halfway through "make test" after adding a
> RETPUSHYES to pp_study, just as an experiment. I went ahead and
> committed it after reading your mail. (I didn't bother to #if
> the remaining code out. I don't see the point.)
>
> I added the RETPUSHYES after the initial sanity checks, to preserve as
> much of the existing caller-visible behaviour as possible. Specifically,
> tests in lib/warnings/9uninit and op/studytied (which tests that study
> $tied calls FETCHSCALAR) and Peek (can't study FBM) continue to pass.
> Apart from that, Peek.t needed some minor tweaking.
>
> Yves: my commit is in the ams/no-more-study branch. Feel free to use it,
> or not, as you wish.
Sounds great, thanks. Could you push it as a smoke-me branch so we can
see what happens?
Yves
--
perl -Mre=debug -e "/just|another|perl|hacker/"
Thread Previous
|
Thread Next