On Fri, 27 Jan 2012 16:10:04 +0000, Nicholas Clark <nick@ccl4.org> wrote: > On Fri, Jan 27, 2012 at 10:58:57AM -0500, David Golden wrote: > > On Fri, Jan 27, 2012 at 10:36 AM, Nicholas Clark <nick@ccl4.org> wrote: > > > to move. This isn't a problem when building from a distribution tarball or > > > other clean checkout, but it is causing "fun" (ie strange noisy catastrophic > > > build failures) when anyone runs git pull on a build checkout, and then > > > runs disclean before starting again. git will correctly delete all the > > > repository files in the old location, but correctly doesn't delete any files > > > created by the build process (eg Makefile), and hence as the directory is > > > not empty git does not delete it. This is enough to confuse Configure. > > > > I regularly use "git clean -dxf" to get back to a pristine, clean > > checkout. (e.g. my "grindperl" tool does that automatically before > > running Configure). It's dangerous to automate for general use as > > "distclean" since it blows away any files manually added, too. > > Possibly -X would be better. > > > > Or perhaps "git clean -dxn" -- dry run mode -- would be enough to > > catch a dirty repo and abort. If that's too draconian, "git clean > > -dn" maybe? > > > > Net: instead of solving the specific case of duplicate directories, > > let's use git to solve the general case of a dirty repo. > > I don't agree. We support building outside of git repositories, because > > a: we distribute tarballs > b: we build on platforms that don't support git even *if* my platforms support git, I use rsync for smokes and never build (production) perls from git repos > We can't assume that > > a: git is present to do our work for us > b: that we can get it to delete all the build files, without also deleting > user owned files. distclean is careful to only delete the things that we > know we built. > > Please also, don't let the perfect be the enemy of the good. > > I've just presented a *working solution* to a current problem. > Even if we adopt your plan, it will do as an interim solution until your > plan delivers a solution. > > Nicholas Clark -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.14 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/Thread Previous