develooper Front page | perl.perl5.porters | Postings from January 2012

Re: [perl #74158] perl2html output concerns

Thread Previous | Thread Next
From:
Marc Green
Date:
January 7, 2012 07:53
Subject:
Re: [perl #74158] perl2html output concerns
Message ID:
CAAL1P-Ev224cinMeeOjKipxS7S9oCOJ6zPbQAm8=ReOMa9hC5Q@mail.gmail.com
On Sat, Jan 7, 2012 at 4:13 AM, Father Chrysostomos via RT <
perlbug-followup@perl.org> wrote:

> Can Marc Green comment on this?
>
> On Sun Apr 11 19:58:06 2010, aristotle wrote:
> > Fixed by the included patch. (Sorry, couldn’t yet figure out how
> > to make `git send-email` work with my setup, or how to make mutt
> > recognise MIME multipart draft messages.)
> >
> > ---
> >  lib/Pod/Html.pm      |    6 ++----
> >  lib/Pod/t/htmlescp.t |    2 +-
> >  lib/Pod/t/htmllink.t |    2 +-
> >  lib/Pod/t/htmlview.t |    2 +-
> >  4 files changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/lib/Pod/Html.pm b/lib/Pod/Html.pm
> > index 6174dd7..8cd981b 100644
> > --- a/lib/Pod/Html.pm
> > +++ b/lib/Pod/Html.pm
> > @@ -455,14 +455,12 @@ sub pod2html {
> >      $Title = html_escape($Title);
> >
> >      my $csslink = '';
> > -    my $bodystyle = ' style="background-color: white"';
> > -    my $tdstyle = ' style="background-color: #cccccc"';
> > +    my $tdstyle = ' style="background-color: #ccc; color: #000"';
> >
> >      if ($Css) {
> >        $csslink = qq(\n<link rel="stylesheet" href="$Css"
> > type="text/css" />);
> >        $csslink =~ s,\\,/,g;
> >        $csslink =~ s,(/.):,$1|,;
> > -      $bodystyle = '';
> >        $tdstyle = '';
> >      }
> >
> > @@ -484,7 +482,7 @@ END_OF_BLOCK
> >  <link rev="made" href="mailto:$Config{perladmin}" />
> >  </head>
> >
> > -<body$bodystyle>
> > +<body>
> >  $block
> >  END_OF_HEAD
> >
> > diff --git a/lib/Pod/t/htmlescp.t b/lib/Pod/t/htmlescp.t
> > index 95942cd..acabf48 100644
> > --- a/lib/Pod/t/htmlescp.t
> > +++ b/lib/Pod/t/htmlescp.t
> > @@ -22,7 +22,7 @@ __DATA__
> >  <link rev="made" href="mailto:[PERLADMIN]" />
> >  </head>
> >
> > -<body style="background-color: white">
> > +<body>
> >
> >
> >  <!-- INDEX BEGIN -->
> > diff --git a/lib/Pod/t/htmllink.t b/lib/Pod/t/htmllink.t
> > index ab11796..19baa62 100644
> > --- a/lib/Pod/t/htmllink.t
> > +++ b/lib/Pod/t/htmllink.t
> > @@ -22,7 +22,7 @@ __DATA__
> >  <link rev="made" href="mailto:[PERLADMIN]" />
> >  </head>
> >
> > -<body style="background-color: white">
> > +<body>
> >
> >
> >  <!-- INDEX BEGIN -->
> > diff --git a/lib/Pod/t/htmlview.t b/lib/Pod/t/htmlview.t
> > index 03fe6e5..c445081 100644
> > --- a/lib/Pod/t/htmlview.t
> > +++ b/lib/Pod/t/htmlview.t
> > @@ -22,7 +22,7 @@ __DATA__
> >  <link rev="made" href="mailto:[PERLADMIN]" />
> >  </head>
> >
> > -<body style="background-color: white">
> > +<body>
> >
> >
> >  <!-- INDEX BEGIN -->
>

I don't know what the "output concerns" are. Could the submitter describe
the problem and how this patch fixes it? Is it as simple as it looks - just
moving the stylings from <body> to <td>, or is there an underlying fix here?

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About