develooper Front page | perl.perl5.porters | Postings from December 2011

[perl #107000] Hint-hash copying can leak

Thread Next
From:
Father Chrysostomos
Date:
December 25, 2011 14:18
Subject:
[perl #107000] Hint-hash copying can leak
Message ID:
rt-3.6.HEAD-14510-1324851508-1265.107000-75-0@perl.org
# New Ticket Created by  Father Chrysostomos 
# Please include the string:  [perl #107000]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=107000 >


If the hint hash is tied and a tie method dies, this variable in hv_copy_hints_hv can leak:

HV *
Perl_hv_copy_hints_hv(pTHX_ HV *const ohv)
{
    HV * const hv = newHV();

The obvious patch, below, would break namespace::clean and B::Hooks::EndOfScope.

Would wrapping the contents of this function in ENTER/LEAVE work?

diff --git a/hv.c b/hv.c
index 1c5e6bc..0e6ed00 100644
--- a/hv.c
+++ b/hv.c
@@ -1448,7 +1448,7 @@ added to it.  A pointer to the new hash is returned.
 HV *
 Perl_hv_copy_hints_hv(pTHX_ HV *const ohv)
 {
-    HV * const hv = newHV();
+    HV * const hv = SvREFCNT_inc_NN(sv_2mortal(newHV()));
 
     if (ohv) {
        STRLEN hv_max = HvMAX(ohv);

---
Flags:
    category=core
    severity=low
---
Site configuration information for perl 5.15.5:

Configured by sprout at Sun Dec 18 11:26:14 PST 2011.

Summary of my perl5 (revision 5 version 15 subversion 5) configuration:
  Snapshot of: 5dca8ed9d28127c9f7a2e7ce5f8ba970da3608cd
  Platform:
    osname=darwin, osvers=10.5.0, archname=darwin-2level
    uname='darwin pint.local 10.5.0 darwin kernel version 10.5.0: fri nov 5 23:20:39 pdt 2010; root:xnu-1504.9.17~1release_i386 i386 '
    config_args='-de -Dusedevel -DDEBUGGING=-g'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
    optimize='-O3 -g',
    cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.2.1 (Apple Inc. build 5664)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib
    libs=-ldbm -ldl -lm -lutil -lc
    perllibs=-ldl -lm -lutil -lc
    libc=, so=dylib, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector'

Locally applied patches:
    

---
@INC for perl 5.15.5:
    /usr/local/lib/perl5/site_perl/5.15.5/darwin-2level
    /usr/local/lib/perl5/site_perl/5.15.5
    /usr/local/lib/perl5/5.15.5/darwin-2level
    /usr/local/lib/perl5/5.15.5
    /usr/local/lib/perl5/site_perl
    .

---
Environment for perl 5.15.5:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/sprout
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin:/usr/local/bin
    PERL_BADLANG (unset)
    SHELL=/bin/bash


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About