[perl #71156] [fwd] [PATCH] Add check for spurious PUSHMARKs by introducing POPBLOCK_normal. (from: gerard@ggoossen.net)

On Fri Dec 02 23:02:38 2011, sprout wrote:
> On Wed Nov 30 22:08:25 2011, sprout wrote:
> > On Wed Nov 30 19:23:00 2011, jkeenan wrote:
> > > The patch attached to the original post makes changes in these files:
> > > 
> > >  cop.h    |   12 ++++++++++++
> > >  pp_ctl.c |   10 +++++-----
> > >  pp_hot.c |    4 ++--
> > > 
> > > Would anyone familiar with these source files care to evaluate the
> patch?
> > 
> > The patch looks good to me
> 
> Not so good, actually:
> 
> $ ./perl harness -v ../cpan/Time-HiRes/t/stat.t
> ../cpan/Time-HiRes/t/stat.t .. 
> 1..1
> # I am the main process 71394, starting the watchdog process...
> # I am the watchdog process 71395, sleeping for 360 seconds...
> # The watchdog process 71395 launched, continuing testing...
> Assertion failed: (PL_markstack_ptr == PL_markstack +
> cx->blk_oldmarksp), function Perl_pp_leaveloop, file pp_ctl.c, line 2296.
> 
> Then the script hangs.

I had to do some manual rebasing to get the patch to apply.  It’s on the
sprout/POPBLOCK_normal branch if anyone wants to try fixing it.

• [perl #71156] [fwd] [PATCH] Add check for spurious PUSHMARKs by introducing POPBLOCK_normal. (from: gerard@ggoossen.net) by Father Chrysostomos via RT