develooper Front page | perl.perl5.porters | Postings from December 2011

Re: [perl.git] branch blead, updated. v5.15.5-275-gbdba49a

Thread Next
Jesse Vincent
December 4, 2011 13:26
Re: [perl.git] branch blead, updated. v5.15.5-275-gbdba49a
Message ID:

It looks like you linked to a set of changes on github and mailed a
single non-git patch containing several changes. Doing so can lead to
confusion and can cause any of the useful information you stuck in your
commit messages to be lost. In the future, when you send patches you'd
like to see applied, it'd be very helpful if you could split out the 
logical patches. If you're not familiar with it, "git help format-patch" 
should get you started.

Father Chrysostomos,

It looks like you applied the patch Shlomi sent to the list, rather than
the actual chunked commits he linked in his mail message.  It looks like
you constructed a new commit message. Unfortunately that new commit
message only tells us what we can trivally divine from a diffstat, not
what it was intended do - for that, we'd have to go read the bug report. 
Commit messages really should be able to stand on their own, so that
someone spelunking code has the information they need easily at hand.



Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About