develooper Front page | perl.perl5.porters | Postings from October 2011

reverting some regcomp fixes

Thread Next
From:
Dave Mitchell
Date:
October 30, 2011 05:07
Subject:
reverting some regcomp fixes
Message ID:
20111030120725.GL3046@iabyn.com
Karl, Father Chrysostomos, would it be okay if I reverted the following
four commits for now? They overlap with the functions that I have currently
been messing with extensively in my davem/re_eval branch (pp_regcomp and
re_compile), and with them in place I'm finding it practically impossible
to rebase my branch; i.e many commits in my branch would need to be
manually merged.

Some of what you've fixed has already been fixed in my branch (although
not pushed yet), but I haven't looked closely yet to see if if there are
still bits to fix.

(Unless someone has a clever suggestion for something I can do with git
instead...)

Thanks.

commit 11951bcbfcaf4c260b0da0421e72fc80b4654f17
Author:     Karl Williamson <public@khwilliamson.com>
AuthorDate: Sat Oct 29 11:20:40 2011 -0600

    PATCH: [perl #101940]: BBC Tk
    
    This commit that turned up this bug turns out merely exposes an
    underlying problem that could be generated via other means.
    
    regcomp.c was looking at the SvUTF8 flag on the input pattern before
    doing an SvPV on it.  Generally the flag is considered not reliable
    unless checked immediately after a SvPV.
    
    I haven't been able to come up with a simple test case that reproduces
    the bug.  I suspect that XS code is required to trigger it.

commit 3e0b93e82af0f1a033bcdb918b413113f1d61cf0
Author:     Karl Williamson <public@khwilliamson.com>
AuthorDate: Sat Oct 29 09:48:43 2011 -0600

    regcomp.c: Use no_mg for 2nd fetch of pattern
    
    The pattern could be tied, for example, and so only want to access it
    once.  I couldn't come up with a test case that actually exercised this,
    but I can think of future changes to regcomp that would.

commit 15d9c083b08647e489d279a1059b4f14a3df187b
Author:     Father Chrysostomos <sprout@cpan.org>
AuthorDate: Sat Oct 29 13:40:06 2011 -0700

    Fix =~ $str_overloaded (5.10 regression)

commit 3e1022372a8200bc4c7354e0f588c7f71584a888
Author:     Father Chrysostomos <sprout@cpan.org>
AuthorDate: Sat Oct 29 13:41:13 2011 -0700

    Remove some repeated code in pp_regcomp

-- 
"Foul and greedy Dwarf - you have eaten the last candle."
    -- "Hordes of the Things", BBC Radio.

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About