develooper Front page | perl.perl5.porters | Postings from October 2011

Re: Smoke [blead] v5.15.4-67-gaba0546 FAIL(F) MSWin32 Win2000 SP4(x86/1 cpu)

Thread Previous | Thread Next
From:
Craig A. Berry
Date:
October 28, 2011 07:37
Subject:
Re: Smoke [blead] v5.15.4-67-gaba0546 FAIL(F) MSWin32 Win2000 SP4(x86/1 cpu)
Message ID:
CA+vYcVzONxEQaCjZZo_1FNXcxidGBZt6YO8xzKje25D_mTVY9Q@mail.gmail.com
On Fri, Oct 28, 2011 at 6:32 AM, Steve Hay <SteveHay@planit.com> wrote:
> Nicholas Clark wrote on 2011-10-28:
>> On Thu, Oct 27, 2011 at 11:30:00PM -0400, George Greer wrote:
>>> Smoke logs available at http://m-l.org/~perl/smoke/perl/
>>>
>>> Automated smoke report for 5.15.4 patch
>> aba0546e5e59b483db69149ae72b8c7a90f9b03f v5.15.4-67-gaba0546
>>
>>> Failures: (common-args) none
>>> [default]
>>> [default] -Duseithreads
>>> [default] -DDEBUGGING -Duseithreads
>>> ../cpan/ExtUtils-MakeMaker/t/echo.t.........................FAILED
>>>     3, 6, 9, 12, 15, 18 Non-zero exit status: 6
>>>
> ../cpan/ExtUtils-MakeMaker/t/MM_Win32.t.....................FAILED
>>>     13-20, 24 Non-zero exit status: 9
>>  From the logs at http://m-
>>
> l.org/~perl/smoke/perl/win32/blead/logaba0546e5e59b483db69149ae72b8c7a9
>> 0f9b03f.log.gz
>
> I don't have time to look into it right now, but here's a little more
> info...
>
>
>>
>> #   Failed test 'contents'
>> #   at t/echo.t line 58.
>> #          got: ''
>> #     expected: 'Foo
>> # '
>> #   Failed test 'contents'#   at t/echo.t line 58.
>
> The Makefile written for this test contains only
>
> FOO=42
> ECHO=$(ABSPERLRUN) -l -e "print qq{@ARGV}" --
>
> all:
>        $(NOECHO) $(ECHO) Foo > bar.txt
>
> It works fine if a definition for ABSPERLRUN is added.

The test doesn't use MakeMaker to generate the Makefile.  It just does:

    # Write a Makefile to test the output of echo
    {
        open my $makefh, ">", "Makefile" or croak "Can't open Makefile: $!";
        print $makefh "FOO=42\n";       # a variable to test with
        print $makefh "ECHO=$mm->{ECHO}\n\n";
        print $makefh "all :\n";
        for my $args (@$calls) {
            print $makefh map { "\t$_\n" } $mm->echo(@$args);
        }
    }

As long as $mm->echo is implemented in terms of a native command (echo
on Unix, write on VMS) this'll work.  But if it depends on $(ECHO) and
that in turn depends on something that's not defined, then obviously
it won't work.  You could try something like:

--- t/echo.t;-3	2011-10-27 07:53:22 -0500
+++ t/echo.t	2011-10-28 09:31:32 -0500
@@ -42,6 +42,7 @@ sub test_for_echo {
     {
         open my $makefh, ">", "Makefile" or croak "Can't open Makefile: $!";
         print $makefh "FOO=42\n";       # a variable to test with
+        print $makefh "ABSPERLRUN=$perl\n";
         print $makefh "ECHO=$mm->{ECHO}\n\n";
         print $makefh "all :\n";
         for my $args (@$calls) {
[end]

FWIW, the test is broken on VMS for three different reasons and I've
only sorted two of them so far.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About