develooper Front page | perl.perl5.porters | Postings from September 2011

Re: Smoke [blead] v5.15.3-33-g0f8d4b5 FAIL(F) linux 2.6.38-11-generic[debian] (x86_64/8 cpu)

Thread Previous | Thread Next
From:
Karl Williamson
Date:
September 22, 2011 21:28
Subject:
Re: Smoke [blead] v5.15.3-33-g0f8d4b5 FAIL(F) linux 2.6.38-11-generic[debian] (x86_64/8 cpu)
Message ID:
4E7C0ACB.7040004@khwilliamson.com
On 09/22/2011 08:29 PM, George Greer wrote:
> Smoke logs available at http://m-l.org/~perl/smoke/perl/
>
> Automated smoke report for 5.15.3 patch 0f8d4b5ec2b14a817d302f2a3e7e311fd574a6bf v5.15.3-33-g0f8d4b5
> zwei: Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz (GenuineIntel 2668MHz) (x86_64/8 cpu)
>      on        linux - 2.6.38-11-generic [debian]
>      using     clang version 4.2.1 Compatible Clang Compiler
>      smoketime 1 hour 25 minutes (average 21 minutes 24 seconds)
>
> Summary: FAIL(F)
>
> O = OK  F = Failure(s), extended report at the bottom
> X = Failure(s) under TEST but not under harness
> ? = still running or test results not (yet) available
> Build failures during:       - = unknown or N/A
> c = Configure, m = make, M = make (after miniperl), t = make test-prep
>
> v5.15.3-33-g0f8d4b5  Configuration (common) -A -Dcc=clang append:ccflags=" -fcatch-undefined-behavior "
> ----------- ---------------------------------------------------------
> O F O F
> O F O F     -Duseithreads
> | +--------- -DDEBUGGING
> +----------- no debugging
>
>
> Locally applied patches:
>      uncommitted-changes
>      SMOKE0f8d4b5ec2b14a817d302f2a3e7e311fd574a6bf
>
> Testsuite was run only with 'harness'
>
> Failures: (common-args) -A -Dcc=clang append:ccflags=" -fcatch-undefined-behavior "
> [minitest]
> [minitest] -DDEBUGGING
> [minitest] -Duseithreads
> [minitest] -DDEBUGGING -Duseithreads
>      t/re/regexp .................... FAILED--unexpected output at test 1539
>      t/re/regexp_noamp .............. FAILED--unexpected output at test 1539
>      t/re/regexp_notrie ............. FAILED--unexpected output at test 1539
>      t/re/regexp_qr ................. FAILED--unexpected output at test 1539
>      t/re/regexp_qr_embed ........... FAILED--unexpected output at test 1539
>      t/re/regexp_trielist ........... FAILED--unexpected output at test 1539
>

This was caused by a patch that added a Todo test.  This is supposed to 
work, but as you can see, it doesn't under minitest.  The problem turns 
out to be that t/re/regexp.t (which all these call) hand rolls its 
tests, instead of using, say, t/test.pl, so that it prints out the 
failure diagnosis without leading '#' signs, a violation of TAP.  The 
attached patch fixes this, but I'm uncertain if it should be applied, so 
am seeking counsel.  The patch copies the _comment() sub from test.pl 
which returns its parameter with every line in it changed to begin with 
a '# '.  And then this is called for multi-line diagnostic output.

The reasons I'm uncertain if doing this is a problem, is why does this 
only fail under minitest?  Why does regular test not care about this 
extra output.  (minitest uses t/TEST).

And _comment() uses regexes to add the comment markers.  And the .t file 
is testing regexes, so things may not be in a good enough state to use 
them.  But the .t file already does have some code that uses regexes to 
test regexes, and the subroutine is good enough for t/test.pl.  So is it 
good enough for this .t?

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About