develooper Front page | perl.perl5.porters | Postings from July 2011

[perl #95992] [PATCH] Call finalize_optree on optree generated by newFORM.

Thread Previous | Thread Next
From:
Gerard Goossen
Date:
July 31, 2011 04:57
Subject:
[perl #95992] [PATCH] Call finalize_optree on optree generated by newFORM.
Message ID:
rt-3.6.HEAD-7815-1312113451-759.95992-75-0@perl.org
# New Ticket Created by  Gerard Goossen 
# Please include the string:  [perl #95992]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=95992 >



This is a bug report for perl from gerard@ggoossen.net,
generated with the help of perlbug 1.39 running under perl 5.15.1.

>From 37fd6491aa42d9b6a6b433323bcd3a4f95831aff Mon Sep 17 00:00:00 2001
From: Gerard Goossen <gerard@ggoossen.net>
Date: Sun, 31 Jul 2011 13:46:34 +0200
Subject: [PATCH] Call finalize_optree on optree generated by newFORM.

finalize_optree should be called on all optrees, thus also on optrees
generated by newFORM.
I don't really understand why this doesn't cause any problems.
---
 op.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/op.c b/op.c
index 915dd78..68aa1a7 100644
--- a/op.c
+++ b/op.c
@@ -6998,6 +6998,7 @@ Perl_newFORM(pTHX_ I32 floor, OP *o, OP *block)
     CvSTART(cv) = LINKLIST(CvROOT(cv));
     CvROOT(cv)->op_next = 0;
     CALL_PEEP(CvSTART(cv));
+    finalize_optree(CvROOT(cv));
 #ifdef PERL_MAD
     op_getmad(o,pegop,'n');
     op_getmad_weak(block, pegop, 'b');
-- 
1.7.5.4

---
Flags:
    category=core
    severity=low
---
Site configuration information for perl 5.15.1:

Configured by gerard at Sun Jul 31 13:41:29 CEST 2011.

Summary of my perl5 (revision 5 version 15 subversion 1) configuration:
  Derived from: 4b5a989e68fb62d6cdebbc9337aed366b3bac767
  Platform:
    osname=linux, osvers=2.6.39-2-686-pae, archname=i686-linux-thread-multi
    uname='linux zeus 2.6.39-2-686-pae #1 smp tue jul 5 03:48:49 utc 2011 i686 gnulinux '
    config_args='-des -DDEBUGGING -Dusethreads -Dusedevel -Doptimize=-O3 -g3 -Dprefix=/home/gerard/perl/inst/madperl'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O3 -g3',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.6.1', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib /usr/lib/i386-linux-gnu /usr/lib64
    libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.13'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O3 -g3 -L/usr/local/lib -fstack-protector'

Locally applied patches:
    

---
@INC for perl 5.15.1:
    lib
    /home/gerard/perl/inst/madperl/lib/site_perl/5.15.1/i686-linux-thread-multi
    /home/gerard/perl/inst/madperl/lib/site_perl/5.15.1
    /home/gerard/perl/inst/madperl/lib/5.15.1/i686-linux-thread-multi
    /home/gerard/perl/inst/madperl/lib/5.15.1
    /home/gerard/perl/inst/madperl/lib/site_perl
    .

---
Environment for perl 5.15.1:
    HOME=/home/gerard
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/gerard/bin:/usr/local/bin:/usr/bin:/bin:/usr/games
    PERL_BADLANG (unset)
    SHELL=/bin/bash


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About