[perl #95034] [PATCH] Use a tempdir & proper filename when viewing a URL via perldoc so the header is displayed correctly(-ish)

On Mon Jul 18 03:12:40 2011, claes wrote:
> This is a bug report for perl from claes@surfar.nu,
> generated with the help of perlbug 1.39 running under perl 5.14.1.
> 

> diff --git a/dist/Pod-Perldoc/lib/Pod/Perldoc.pm
b/dist/Pod-Perldoc/lib/Pod/Perldoc.pm
> index b8c9181..f120cb2 100644
> --- a/dist/Pod-Perldoc/lib/Pod/Perldoc.pm
> +++ b/dist/Pod-Perldoc/lib/Pod/Perldoc.pm
> @@ -728,9 +728,13 @@ sub grand_search_init {
>              require File::Temp;
>              my $response = HTTP::Tiny->new->get($_);
>              if ($response->{success}) {
> -                my ($fh, $filename) = File::Temp::tempfile(UNLINK => 1);
> -                $fh->print($response->{content});
> -                push @found, $filename;
> +                my $filename = $_ =~ m{.*/([^/#?]+)} ? $1 :
"Unknown.pod";
> +                my $dir = File::Temp::tempdir(CLEANUP => 1);
> +                my $path = catfile $dir, $filename;
> +                open my $fh, ">", $path or die "Can't open $filename:
$!";
> +                print $fh $response->{content};
> +                push @found, $path;
> +                close $fh;
>              }
>              else {

That approach won’t work for really long base names. And on Windoze it
will fail with base names containing : or consisting of ‘prn’ or a few
other special names. On VMS it won’t work with multiple dots in the file
name.

Where exactly is the header set? Maybe that piece of code could be
modified. Does Pod::Man need a new option, perhaps?

• [perl #95034] [PATCH] Use a tempdir & proper filename when viewing a URL via perldoc so the header is displayed correctly(-ish) by Father Chrysostomos via RT
• Re: [perl #95034] [PATCH] Use a tempdir & proper filename when viewing a URL via perldoc so the header is displayed correctly(-ish) by Claes Jakobsson