develooper Front page | perl.perl5.porters | Postings from July 2011

Re: [PATCH] export store_cop_label

Thread Previous | Thread Next
Father Chrysostomos
July 16, 2011 18:47
Re: [PATCH] export store_cop_label
Message ID:

On Jul 3, 2011, at 1:26 PM, Father Chrysostomos wrote:

> On Jun 28, 2011, at 5:02 AM, Reini Urban wrote:
>> 2011/6/26 Father Chrysostomos <>:
>>> Reini Urban wrote:
>>>> Attached is a slightly revised patch. make regen required.
>>> If we are going to make this a public API, shouldn't the functions
>>> begin with cop_, for consistency with other parts of the API (hv func-
>>> tions begin with hv_, sv functions begin with sv_)? Apart from that,
>>> it looks good to me, and I'd like to see this go into 5.16. Whether it
>>> makes it into 5.14 and .12 is up to Jesse.
>> That's a good point.
>> cop_store_label and cop_fetch_label then?
> Those sound good to me.

I’ve just applied your patch as 8375c93eec56 and renamed the functions with commit aebc0cbee0.
Thank you.
Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About