Front page | perl.perl5.porters |
Postings from July 2011
______________________________________ From: Father Chrysostomos via RT [perlbug-followup@perl.org] Sent: Sunday, July 03, 2011 9:48 PM To: Green, Marc Evan Subject: [perl #93878] [PATCH] eol.t: Don't test for CR as line separator as that is deprecated On Sun Jul 03 14:41:27 2011, ponguile@gmail.com wrote: > > > > Even if something is deprecated, but still supported, shouldnt we > > continue to test for it, until the deprecated feature is removed? > > > > Sorry, it is not supported any more either. I discussed this issue on #p5p > but I cannot find the logs to prove it. >Then how are the tests currently passing? Im confused. The tests use Pod::Html which *does* technically support '\r' as a line separator -- it does a global s/\r/\n/ -- but pjcj enlightened me that that behavior is no longer supported (see below). Note that I am currently refactoring Pod::Html and it no longer will support \r as a line separator. Jun 30 18:42:37 <marcg> a question about lib/Pod/t/eol.t: why should '\r' be treated as a newline? Jun 30 18:42:52 <marcg> I understand why \r\n is, but why just \r? Jun 30 18:43:14 <claes> marcg: macos classic used that as line separator Jun 30 18:43:50 <marcg> thanks claes Jun 30 18:43:58 <pjcj> but we don't support that any more, and I don't think anything else uses it Jun 30 19:08:45 <marcg> pjcj, so can I remove that part of the test? Jun 30 19:09:56 <pjcj> I would imagine so, but it's hard to be sure Jun 30 19:10:14 <pjcj> asking on the list, possibly with your patch, might be wiseThread Previous | Thread Next