Re: [PATCH] Add "b <filename>:<line> <cond>" to perl -d

Shlomi Fish wrote:
> Hi all!
> 
> This link - http://xrl.us/bjrpd2 is a github branch that contains a set of 
> some commits to add this to perl -d :
> 
> <POD>
> 
> =item b [file]:[line] [condition]
> X<breakpoint>
> X<debugger command, b>
> 
> Set a breakpoint before the given line in a (possibly different) file.  If a
> condition is specified, it's evaluated each time the statement is reached: a
> breakpoint is taken only if the condition is true.  Breakpoints may only be 
> set
> on lines that begin an executable statement.  Conditions don't use C<if>:
> 
>     b lib/MyModule.pm:237 $x > 30
>     b /usr/lib/perl5/site_perl/CGI.pm:100 ++$count100 < 11
> 
> </POD>
> 
> I promised this earlier and I did not completely forget about it.
> 
> I don't expect it to get in before perl-5.14.0 is, but it's there if anyone is 
> interested. Some of the "make test" fail but it seems to be a problem with 
> t/porting/cmp_version.t .

When I first tried applying this some time ago, all tests passed. Just now when I tried merging it with blead, I got this failure:

$ cd t
$ ./perl TEST ../lib/perl5db.t
t/../lib/perl5db....# Failed at ../lib/perl5db.t line 199
#      got 'In MyModule.
# In Main File.
# Var=
# '
# expected /(?^msx:
#         ^Var=Bar$
#             .*
#         ^In\ MyModule\.$
#             .*
#         ^In\ Main\ File\.$
#             .*
#         )/
FAILED at test 10
Failed 1 test out of 1, 0.00% okay.
	../lib/perl5db.t

Is there any chance you could look into that? Just it case it was a mistake in the way I applied it, attached is what I applied.

(BTW, I find it a lot easier to apply things if they are sent as attachments to perlbug@perl.org.)

• [PATCH] Add "b <filename>:<line> <cond>" to perl -d by Shlomi Fish
• Re: [PATCH] Add "b <filename>:<line> <cond>" to perl -d by Father Chrysostomos
• Re: [PATCH] Add "b <filename>:<line> <cond>" to perl -d by Shlomi Fish
• Re: [PATCH] Add "b <filename>:<line> <cond>" to perl -d by Joshua ben Jore
• Re: [PATCH] Add "b <filename>:<line> <cond>" to perl -d by Father Chrysostomos