Front page | perl.perl5.porters |
Postings from May 2011
On Tue May 31 05:56:57 2011, davem wrote: > On Sun, May 29, 2011 at 09:29:49PM +0100, Dave Mitchell wrote: > > On Sun, May 29, 2011 at 12:54:45PM -0700, Father Chrysostomos via RT > wrote: > > > On Wed May 25 12:40:13 2011, rmbarker.cpan@btinternet.com wrote: > > > > This misbehaviour first appeared at > > > > commit 815f25c6e302f84ecce02c74fa717a19d787f662 > > > > Author: Dave Mitchell <davem@fdisolutions.com> > > > > Date: Sat May 10 02:45:23 2003 +0100 > > > > > > > > The code prior to that change suggests that C<maxops += 10> > should be > > > > C<maxopss += 3>. > > > > > > > > This patch follows that suggestion and includes the previous > patch from > > > > Nicholas Clark and passes all tests. > > > > > > Did you compile with -DDEBUGGING? I tried your patch and got an > > > assertion failure: > > > > > > Assertion failed: (fpc <= fops + maxops), function S_doparseform, > file > > > pp_ctl.c, line 5118. > > > > > > I’m probably too late in responding, because I see Dave Mitchell > has > > > made about two dozens commits with various fixes to formline, > notably > > > 3808a68. > > > > Hang about, I'm confused now. All the failures I saw were in > pp_parseform, > > related to buffer overruns in PL_formtarget. I never saw the > assertion > > failure in S_doparseform, and none of my commits would have > addressed such > > a failure. I only got an assertion failure when I tried out Robin’s patch. So I didn’t push it. > > But regardless, Robin's patch looks successful. ? > > Can anyone see the assertion failure since my series of commits? No. Nor was there one before that.Thread Previous | Thread Next