develooper Front page | perl.perl5.porters | Postings from May 2011

Re: [perl #91032] Invalid free in t/op/write.t

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
May 29, 2011 13:30
Subject:
Re: [perl #91032] Invalid free in t/op/write.t
Message ID:
20110529202949.GB3593@iabyn.com
On Sun, May 29, 2011 at 12:54:45PM -0700, Father Chrysostomos via RT wrote:
> On Wed May 25 12:40:13 2011, rmbarker.cpan@btinternet.com wrote:
> > This misbehaviour first appeared at 
> > commit 815f25c6e302f84ecce02c74fa717a19d787f662
> > Author: Dave Mitchell <davem@fdisolutions.com>
> > Date:   Sat May 10 02:45:23 2003 +0100
> > 
> > The code prior to that change suggests that C<maxops += 10> should be
> > C<maxopss += 3>.
> > 
> > This patch follows that suggestion and includes the previous patch from
> > Nicholas Clark and passes all tests. 
> 
> Did you compile with -DDEBUGGING? I tried your patch and got an
> assertion failure:
> 
> Assertion failed: (fpc <= fops + maxops), function S_doparseform, file
> pp_ctl.c, line 5118.
> 
> I’m probably too late in responding, because I see Dave Mitchell has
> made about two dozens commits with various fixes to formline, notably
> 3808a68.

Hang about, I'm confused now. All the failures I saw were in pp_parseform,
related to buffer overruns in PL_formtarget. I never saw the assertion
failure in S_doparseform, and none of my commits would have addressed such
a failure.


-- 
All wight. I will give you one more chance. This time, I want to hear
no Wubens. No Weginalds. No Wudolf the wed-nosed weindeers.
    -- Life of Brian

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About