develooper Front page | perl.perl5.porters | Postings from April 2011

Re: [PATCH] export store_cop_label

Thread Previous | Thread Next
From:
Reini Urban
Date:
April 13, 2011 22:43
Subject:
Re: [PATCH] export store_cop_label
Message ID:
BANLkTikrrTZ7Un50_jhyyTpk30eR03G3zg@mail.gmail.com
2011/4/13 Jan Dubois <jand@activestate.com>:
> On Wed, 13 Apr 2011, Reini Urban wrote:
>> 2011/4/13 Jan Dubois <jand@activestate.com>:
>>> On Tue, 12 Apr 2011, Reini Urban wrote:
>>>>
>>>> https://github.com/rurban/perl/commit/3691eaa79cc6a196b6a424b4c7abc6c8f5a481e2
>>>> contains the full store_cop_label patch.
>>>
>>> Thanks!  I've attached a comment on github that the symbol should be
>>> marked with "A" and not "EX" if you want to use it from outside the
>>> core distribution.
>>
>> I only see it useful for the compilers, so EX.
>
> B::C is not in ext/ inside the core, so "EX" does not apply. If you want
> to use it from CPAN, is has to be "A". From the core point of view,
> nothing on CPAN is "more special" than everything else.
>
> Claiming upfront that you intend to ignore the spirit of the rules
> anyways just makes it so much harder to get your patch accepted, so
> please don't do that!

As you want.

Sam asked if C code is utf-8 safe. It need not to be. I choose a char
which is most likely represented in Latin-1. Just stored with the utf8
flag, to check if the utf8 flags survives a roundtrip. It does not
matter if the "ä" german umlaut a is actually encoded as latiin-1 or
utf-8.

The 0755 global.sym was a mistake. If applied please fix this.
-- 
Reini

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About