develooper Front page | perl.perl5.porters | Postings from March 2011

Use "make minitest" to test miniperl (Doh!) (Re: [perl.git] branchblead, updated. v5.13.10-206-g59d6f6a)

Thread Previous
From:
Craig A. Berry
Date:
March 5, 2011 20:01
Subject:
Use "make minitest" to test miniperl (Doh!) (Re: [perl.git] branchblead, updated. v5.13.10-206-g59d6f6a)
Message ID:
craigberry-A8A464.22012005032011@cpc2-bmly6-0-0-cust974.2-3.cable.virginmedia.com
In article <E1PvwJK-00007d-Ba@camel.ams6.corp.booking.com>,
 nick@ccl4.org ("Nicholas Clark") wrote:

> In perl.git, the branch blead has been updated
> 
> <http://perl5.git.perl.org/perl.git/commitdiff/59d6f6a4c05afa7f69dc616d7a7f744
> 6ceb5433a?hp=816005240f1a3b9989c940e630e829048597537c>
> 
> - Log -----------------------------------------------------------------
> commit 59d6f6a4c05afa7f69dc616d7a7f7446ceb5433a
> Author: Nicholas Clark <nick@ccl4.org>
> Date:   Sat Mar 5 18:14:47 2011 +0000
> 
>     Avoid miniperl SEGVing when processing -I on the #! line
>     
>     A side-effect of change 3185893b8dec1062 was to force av in S_incpush() 
>     to be
>     NULL, whilst other flag variables were still set as if it were non-NULL, 
>     for
>     certain cases, only when compiled with -DPERL_IS_MINIPERL

Urk.  My bad.  I did run the full test suite in two configurations on 
two very different platforms, but I hadn't clued in to the fact that 
"make minitest" actually does a better job of testing miniperl than the 
full test suite does.  To atone for my sins, I've committed the 
following:

% git show cd78e84f5db4f47c7267c4300aa8ea157e1317a2
commit cd78e84f5db4f47c7267c4300aa8ea157e1317a2
Author: Craig A. Berry <craigberry@mac.com>
Date:   Sat Mar 5 21:57:20 2011 -0600

    Document running "make minitest" to test miniperl.

diff --git a/pod/perlgit.pod b/pod/perlgit.pod
index e10fee6..eac7bb8 100644
--- a/pod/perlgit.pod
+++ b/pod/perlgit.pod
@@ -760,6 +760,13 @@ If you don't run the full test suite, at least 
C<make test_porting>.
 This will run basic sanity checks. To see which sanity checks, have a
 look in F<t/porting>.

+=item *
+
+If you make any changes that affect miniperl or core routines that have
+different code paths for miniperl, be sure to run C<make minitest>.
+This will catch problems that even the full test suite will not catch
+because it runs a subset of tests under miniperl rather than perl.
+
 =back

 =head2 Committing to maintenance versions

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About