develooper Front page | perl.perl5.porters | Postings from January 2011

Re: [PATCH 2/3] modernise package variable style

Thread Previous | Thread Next
From:
Eric Brine
Date:
January 31, 2011 09:25
Subject:
Re: [PATCH 2/3] modernise package variable style
Message ID:
AANLkTi==sQpo3CgB1trbWcHZnHJLA8orVCaT42hQ=e2c@mail.gmail.com
On Mon, Jan 31, 2011 at 3:27 AM, Aristotle Pagaltzis <pagaltzis@gmx.de>wrote:

> > <<use vars>> should be used instead of <<our>> for vars that
> > can be accessed from outside the module to prevent "used only
> > once" warnings. Switching <<$SIGACTION_FLAGS>> to <<our>> is
> > a mistake. It causes proper usage of that variable to warn.
>

hum, I seem to be mistaken.

$ md Mod

$ cat > Mod/Vars.pm
package Mod::Vars;
use vars qw( $CONFIG );
sub f { print "$CONFIG\n"; }
1;

$ cat > Mod/Our.pm
package Mod::Our;
our $CONFIG;
sub f { print "$CONFIG\n"; }
1;

$ perl -we'use Mod::Vars; local $Mod::Vars::CONFIG = 1; Mod::Vars::f();'
1

$ perl -we'use Mod::Our; local $Mod::Our::CONFIG = 1; Mod::Our::f();'

So I hereby state that I don’t know what you’re talking about.
>

Apparently, that makes two of us! I retract what I said. It doesn't seem
that whatever I'm thinking about is relevant here.

- Eric

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About