develooper Front page | perl.perl5.porters | Postings from January 2011

[PATCH 2/3] modernise package variable style

Thread Previous | Thread Next
From:
Aristotle Pagaltzis
Date:
January 30, 2011 14:02
Subject:
[PATCH 2/3] modernise package variable style
Message ID:
20110130220204.GB31609@klangraum.plasmasturm.org
---
 ext/POSIX/lib/POSIX.pm |   18 ++++++++----------
 1 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/ext/POSIX/lib/POSIX.pm b/ext/POSIX/lib/POSIX.pm
index 1ef4bbe..29e06a9 100644
--- a/ext/POSIX/lib/POSIX.pm
+++ b/ext/POSIX/lib/POSIX.pm
@@ -2,7 +2,7 @@ package POSIX;
 use strict;
 use warnings;
 
-our(@ISA, %EXPORT_TAGS, @EXPORT_OK, @EXPORT, $AUTOLOAD, %SIGRT) = ();
+our %SIGRT;
 
 our $VERSION = "1.24";
 
@@ -150,11 +150,11 @@ package POSIX::SigRt;
 use AutoLoader 'AUTOLOAD';
 
 use Tie::Hash;
+our @ISA = qw(Tie::StdHash);
 
-use vars qw($SIGACTION_FLAGS $_SIGRTMIN $_SIGRTMAX $_sigrtn @ISA);
-@POSIX::SigRt::ISA = qw(Tie::StdHash);
+our ($_SIGRTMIN, $_SIGRTMAX, $_sigrtn);
 
-$SIGACTION_FLAGS = 0;
+our $SIGACTION_FLAGS = 0;
 
 tie %POSIX::SIGRT, 'POSIX::SigRt';
 
@@ -522,7 +522,7 @@ sub utime {
 }
 
 sub load_imports {
-%EXPORT_TAGS = (
+our %EXPORT_TAGS = (
 
     assert_h =>	[qw(assert NDEBUG)],
 
@@ -678,10 +678,10 @@ sub load_imports {
   @export{map {@$_} values %EXPORT_TAGS} = ();
   # Doing the de-dup with a temporary hash has the advantage that the SVs in
   # @EXPORT are actually shared hash key scalars, which will save some memory.
-  push @EXPORT, keys %export;
+  our @EXPORT = keys %export;
 }
 
-@EXPORT_OK = qw(
+our @EXPORT_OK = qw(
 		abs
 		alarm
 		atan2
@@ -789,9 +789,7 @@ sub _check {
 sub new {
     my ($rtsig, $handler, $flags) = @_;
     my $sigset = POSIX::SigSet->new($rtsig);
-    my $sigact = POSIX::SigAction->new($handler,
-				       $sigset,
-				       $flags);
+    my $sigact = POSIX::SigAction->new($handler, $sigset, $flags);
     POSIX::sigaction($rtsig, $sigact);
 }
 
-- 
1.7.3


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About