Front page | perl.perl5.porters |
Postings from December 2010
Greetings again,
On Fri, Dec 24, 2010 at 9:51 PM, Ronald J Kimball <rjk@tamias.net> wrote:
> There's an error in this block:
>
> + if ($filename =~ tr/././ > 1) {
> + fail("more than one dot: $filename") unless $filename =~ m/(tar|tgz|gz)/;
> + return;
> + }
>
> You shouldn't return without failing. Try this:
>
> if ($filename =~ tr/././ > 1 and $filename !~ /\.(tar|tgz|gz)\z/) {
> fail("more than one dot: $filename");
> return;
> }
Well spotted, patch updated. Thank you.
> Ronald
smash
Thread Previous
|
Thread Next