develooper Front page | perl.perl5.porters | Postings from December 2010

Re: Task for new porter (Re: perldelta naming)

Thread Previous | Thread Next
From:
Ronald J Kimball
Date:
December 24, 2010 13:51
Subject:
Re: Task for new porter (Re: perldelta naming)
Message ID:
20101224215110.GD62083@penkwe.pair.com
There's an error in this block:

+    if ($filename =~ tr/././ > 1) {
+        fail("more than one dot: $filename") unless $filename =~ m/(tar|tgz|gz)/;
+        return;
+    }

You shouldn't return without failing.  Try this:

if ($filename =~ tr/././ > 1 and $filename !~ /\.(tar|tgz|gz)\z/) {
  fail("more than one dot: $filename");
  return;
}

Ronald

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About