develooper Front page | perl.perl5.porters | Postings from December 2010

Re: Task for new porter (Re: perldelta naming)

Thread Previous | Thread Next
From:
Nuno 'smash' Carvalho
Date:
December 22, 2010 04:19
Subject:
Re: Task for new porter (Re: perldelta naming)
Message ID:
AANLkTi=ZC3gd4Q6nd=bruH4QY3nVYFjWcm3nrwGJjDnw@mail.gmail.com
Hi again,

On Wed, Dec 22, 2010 at 12:04 AM, Tony Cook <tony@develop-help.com> wrote:
> On Tue, Dec 21, 2010 at 12:14:17AM +0000, Nuno 'smash' Carvalho wrote:
>>  Here is a first attempt to write the filenames.t test file. Some
>> tests discussed in the list were added, not all I think. Any comments,
>> suggestions, etc. are welcome. A couple of tests fail because of file
>> names with more than one . (dot) in the MANIFEST.
>
> I see one issue with the DOS device filename checks:
>
> +    foreach (@dont) {
> +        if ($before =~ m/$_\./i) {
> +            fail("found $_ before the dot: $filename");
> +            return;
> +        }
> +    }
>
> A filename "fooprn.pm" is acceptable, but this code will reject it.
>
> A filename "foo/prn.pm" is not acceptable.

 A new patch attached to this message that solves this issue. Thank
you for you comments.

> Tony

smash

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About