develooper Front page | perl.perl5.porters | Postings from December 2010

Re: Task for new porter (Re: perldelta naming)

Thread Previous | Thread Next
Tony Cook
December 21, 2010 16:05
Re: Task for new porter (Re: perldelta naming)
Message ID:
On Tue, Dec 21, 2010 at 12:14:17AM +0000, Nuno 'smash' Carvalho wrote:
>  Here is a first attempt to write the filenames.t test file. Some
> tests discussed in the list were added, not all I think. Any comments,
> suggestions, etc. are welcome. A couple of tests fail because of file
> names with more than one . (dot) in the MANIFEST.

I see one issue with the DOS device filename checks:

+    foreach (@dont) {
+        if ($before =~ m/$_\./i) {
+            fail("found $_ before the dot: $filename");
+            return;
+        }
+    }

A filename "" is acceptable, but this code will reject it.

A filename "foo/" is not acceptable.


Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About