develooper Front page | perl.perl5.porters | Postings from December 2010

[perl #80318] PATCH: various small fixes, including \d, \s for locale

Thread Previous
From:
karl williamson
Date:
December 6, 2010 13:00
Subject:
[perl #80318] PATCH: various small fixes, including \d, \s for locale
Message ID:
rt-3.6.HEAD-13564-1291669219-1197.80318-75-0@perl.org
# New Ticket Created by  karl williamson 
# Please include the string:  [perl #80318]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=80318 >


Yves informed me that I had been misled by the comments in regcomp.sym 
into thinking all new nodes had to come at the end.  So this patch 
series includes moving them around to sensible groups.

It also fixes an EBCDIC-only bug that I overlooked in an earlier patch

And adds support for locales and \d, \D correctly.  There were several 
places wrong, including the node definitions in regcomp.sym, and the 
fact that they weren't being generated in regcomp.c, and only some 
places in regexec.c that should have them actually did.

These came out in the .t testing, so there is some locale tests that work.

I also noticed that SPACE was hard-coded into locale handling of \s and 
\S.  This shouldn't be.  It appears to have been a sloppy cut-paste job.

These are also available at
https://github.com/khwilliamson/perl.git
branch regex

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About