develooper Front page | perl.perl5.porters | Postings from September 2010

Re: [perl #76678] [PATCH] Locale::Maketext - Import dev changes from CPAN

Thread Previous | Thread Next
From:
Todd Rinaldo
Date:
September 28, 2010 11:04
Subject:
Re: [perl #76678] [PATCH] Locale::Maketext - Import dev changes from CPAN
Message ID:
5FBF8D9C-EB15-4A90-BF17-C6DAFE92D418@cpanel.net

On Sep 26, 2010, at 10:34 PM, Father Chrysostomos via RT wrote:

> 
> And I *thought* I had run the tests. It’s now failing like this:
> 
> $ ./perl harness -v ../dist/Locale-Maketext/t/70_fail_auto.t 
> ../dist/Locale-Maketext/t/70_fail_auto.t .. 
> 1..5
> ok 1 - use Locale::Maketext;
> ok 2 - simple missing keys are handled
> #   Failed test 'even in repeated calls'
> #   at t/70_fail_auto.t line 26.
> #          got: undef
> #     expected: 'abcd'
> 
> not ok 3 - even in repeated calls
> ok 4 - keys with bracket notation ok
> ok 5 - keys which start with _ ok# Looks like you failed 1 test of 5.
> 
> So I’ve just reverted it. Maybe I should let someone else take over or
> do it when I’m more awake. :-)
> 
> The revert commits are:
> 6797b0fef2e51d44193184687a5343e7bd3b5874
> 213a5d2cb3aa3b5c246b024e7e9c9903eba9decf
> 
Thanks for your time and sorry for the forced revert. I accidentally diffed 1.13_80 with 1.13_82 instead of comparing 1.13 to 1.13_82 

It turns out there's only a 2 line difference but it's an important one.

I've attached a proper git commit for inclusion. Tests pass in this case.

Todd


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About