develooper Front page | perl.perl5.porters | Postings from September 2010

[perl #76678] [PATCH] Locale::Maketext - Import dev changes from CPAN

Thread Previous | Thread Next
From:
Father Chrysostomos via RT
Date:
September 26, 2010 20:35
Subject:
[perl #76678] [PATCH] Locale::Maketext - Import dev changes from CPAN
Message ID:
rt-3.6.HEAD-24759-1285558495-232.76678-15-0@perl.org
On Sun Sep 26 20:18:25 2010, sprout wrote:
> On Sun Sep 26 18:32:39 2010, sprout wrote:
> > On Thu Jul 22 12:52:47 2010, toddr@cpanel.net wrote:
> > > This patch imports the changes which are on CPAN but not already
> > >    pulled into blead for Locale::Maketext.
> > > 
> > > 1. New test file  t/70_fail_auto.t - Test for CPAN RT #25877
> > > 2. Convert  t/30_local.t to Test::More (the other files were already
> > >    done in blead. This one was missed.
> > > 3. Add a cookbook pod file.
> > > 4. Changelog entries which were on CPAN but not in blead.
> > > 
> > > I'll add Changelog entries for recent stuff when 1.15 is complete on
> > >    blead. There are 4 patches still pending.
> > 
> > Not seeing these entries, and not knowing about the dev releases, I
> > copied some change log entries from perldelta into the ChangeLog file.
> > Some of these may be duplicates. Can I leave it to you to determine
> > what’s what?
> > 
> > Also, I screwed up the patch application and ended up with your name in
> > the commit message instead of the author field. Sorry about that!
> 
> And I also forgot to mention it was
> 213a5d2cb3aa3b5c246b024e7e9c9903eba9decf....

And I *thought* I had run the tests. It’s now failing like this:

$ ./perl harness -v ../dist/Locale-Maketext/t/70_fail_auto.t 
../dist/Locale-Maketext/t/70_fail_auto.t .. 
1..5
ok 1 - use Locale::Maketext;
ok 2 - simple missing keys are handled
#   Failed test 'even in repeated calls'
#   at t/70_fail_auto.t line 26.
#          got: undef
#     expected: 'abcd'

not ok 3 - even in repeated calls
ok 4 - keys with bracket notation ok
ok 5 - keys which start with _ ok# Looks like you failed 1 test of 5.

So I’ve just reverted it. Maybe I should let someone else take over or
do it when I’m more awake. :-)

The revert commits are:
6797b0fef2e51d44193184687a5343e7bd3b5874
213a5d2cb3aa3b5c246b024e7e9c9903eba9decf


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About