Front page | perl.perl5.porters |
Postings from September 2010
[PATCH] hint APIs
Thread Next
From:
Zefram
Date:
September 11, 2010 18:00
Subject:
[PATCH] hint APIs
Message ID:
20100912010011.GO32401@lake.fysh.org
Attached patch API-ifies a bunch of hint-related things. The bulk of
it is making the refcounted_he system public, but note that this doesn't
particularly publicise the fact that hints in cops are implemented using
refcounted_he. refcounted_he is a reasonable data structure to support
independent of this usage.
I'm not entirely happy about the details of Ben's cop_hints_fetch API.
It's very sensible to have an API at this level (and I made more
places use it), and it's got the right functions, but the flags aren't
handled as cleanly as they should. Using an HVhek flag exposes too much
implementation (which this patch changes anyway). The pvs interface
ought to accept a flags parameter to allow literal UTF-8 strings, and
the sv interface probably ought to have a flags parameter in case we
define any other flags in the future. I'll probably work up a patch to
fix these things.
-zefram
Thread Next
-
[PATCH] hint APIs
by Zefram