develooper Front page | perl.perl5.porters | Postings from September 2010

Re: [PATCH] Damian will probably hate me

Thread Previous | Thread Next
From:
Tony Cook
Date:
September 10, 2010 17:01
Subject:
Re: [PATCH] Damian will probably hate me
Message ID:
20100911000037.GA15408@mars.tony.develop-help.com
On Thu, Sep 09, 2010 at 09:08:08PM -0400, Jesse Vincent wrote:
> 
> 
> 
> On Fri, Sep 10, 2010 at 10:52:39AM +1000, Tony Cook wrote:
> > On Wed, Sep 08, 2010 at 10:17:07AM +0200, Rafael Garcia-Suarez wrote:
> > > On 24 August 2010 22:24, Zefram <zefram@fysh.org> wrote:
> > > > Attached patch fixes the mess around qw syntax.  "make regen regen_perly"
> > > > required.  Patch also available at git://lake.fysh.org/zefram/perl.git
> > > > branch zefram/qw_strong.
> > > 
> > > Thanks, applied to blead as ea25a9b2cf73948b1e8c5675de027e0ad13277bd
> > > (by hand, since there were conflicts in perly.y.)
> > 
> > This patch broke -Dmad.
> > 
> > Do we remove -Dmad or fix it?
> 
> I would be deeply, deeply sad if mad were removed. 

So if -Dmad is a configuration we want to support, this patch broke
the build, and it's been broken for two days.

Do we leave patches that break the build in the tree?  For how long?

I've looked at it myself, but I don't see how to fix it.

Tony

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About