Front page | perl.perl5.porters |
Postings from September 2010
On 4 September 2010 17:07, Ben Morrow <ben@morrow.me.uk> wrote:
> Quoth ben@morrow.me.uk (Ben Morrow):
>> Quoth rafl@debian.org (Florian Ragwitz):
>> >
>> > I'm not fully happy with the naming.
>> >
>> > All other hints-related code in the core I've seen so far refers to the
>> > hints hash as "hints", not "hinthash". Also a function called
>> > hinthash_2hv not actually taking a hinthash but returning the hinthash
>> > as an HV seems slightly off.
>> >
>> > cop_fetch_hint_hv/cop_fetch_hint_{x,sv,pvn,pvs}, maybe?
>>
>> I agree, though I think I prefer cop_hints_fetch(sv|pv[ns]) and
>> cop_hints_2hv. I think the '2hv' is important, because it isn't
>> returning the actual hinthash but rather a copy of it.
>
> OK, I've done up a new patch with these names.
Thanks, applied to bleadperl as
8dff4fc578385a16edd29a881d85a0aa5f09595a and following.
Thread Previous