Front page | perl.perl5.porters |
Postings from September 2010
On Sun Sep 05 12:48:50 2010, sprout@cpan.org wrote:
> On Aug 31, 2010, at 10:24 AM, Florian Ragwitz wrote:
> > Without those 4 lines, all the tests still pass.
>
> Thatâs because there are not enough tests. Iâve attached a test for
> @main::ISA. I managed to get âuse overloadâ from main to produce
> warnings, but I canât reproduce it in a test script without
> fresh_perl. Is there any reason we couldnât switch lib/overload.t
> over to test.pl?
The only reason I could think of was test.pl using overloading, which
doesn't seem to be the case, so this change should be safe, and an
additional test for main::OVERLOAD in addition to main::ISA would seem
like a very useful thing.
> > In that test, you do
> >
> > +sub tests'VERSION { $tests += pop };
> >
> > Is using ' instead of :: there actually relevant to the test? It
> seems
> > like there's a pretty broad consensus on not doing that anymore for
> new
> > code within the core.
>
> OK, Iâve changed it. That was copied and pasted from elsewhere. But
> doesnât it make it less likely that weâll catch buggy interactions
> between features if we try to keep the tests too standardised?
Yes, possibly. I've asked that question on irc, and the answer I got
from our pumpkin was "Don::t", which I relayed to you. I'm not entirely
what the reasoning behind it was.
> Attached is a new patch.
Thank you. I applied this to blead with some minor modifications. I did
s/magicalise/magicalize/ in gv.c, as "magicalize" was already used in a
couple of places there, while "magicalise" wasn't at all, and I changed
the value t/op/leaky-magic.t assigns to the special $^Variables in order
to avoid a warning when assigning something containing invalid -D flags
to $^D.
Thread Previous
|
Thread Next