develooper Front page | perl.perl5.porters | Postings from August 2010

Re: [perl #75176] Symbol::delete_package does not free certain memory associated with package::ISA

Thread Previous | Thread Next
From:
Father Chrysostomos
Date:
August 29, 2010 17:13
Subject:
Re: [perl #75176] Symbol::delete_package does not free certain memory associated with package::ISA
Message ID:
F18F231B-714F-4BFD-8EEA-DE5F20C75335@cpan.org

On Aug 29, 2010, at 3:20 PM, demerphq wrote:

> On 29 August 2010 23:09, Father Chrysostomos <sprout@cpan.org> wrote:
> +	if (stype == SVt_PVHV) {
> +	    const char * const name = GvNAME((GV*)dstr);
> +	    const STRLEN len = GvNAMELEN(dstr);
> +	    if (len > 1 && name[len-2] == ':' && name[len-1] == ':')
> +		if(HvNAME(dref)) mro_package_moved((HV *)dref);
> +		if(HvNAME(sref)) mro_package_moved((HV *)sref);
> +	}
> 
> Did you miss a { } there? From the indenting it looks like the if ()
> applies to both of the following ifs, but it is an if (EXPR) STMT; not
> an IF (EXPR) BLOCK

Thank you for catching that. Here is a fixed version.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About