Front page | perl.perl5.porters |
Postings from August 2010
On Sun, 22 Aug 2010, David Golden wrote:
> I think other open source efforts with more formal organizational
> structures don't have a problem being public with who has commit
> rights or recognizing such a group as having a different level of
> "trust/responsibilty" (I'm thinking of FreeBSD for example).
I was about to say that you can easily find out the list of Perl5
committers with something like:
git log --pretty=format:%cn | sort | uniq
But then I noticed that the list contains various people without commit
access to the core repo. For example this commit:
http://perl5.git.perl.org/perl.git/commit/735302bdcf24a4ddbec0844a789296bc22cbb505
It lists Shlomi as the committer while it actually has been merged/pushed
to the core repo by rgs. But the only way I could find that out was by
looking at the perl5-changes archives:
http://www.nntp.perl.org/group/perl.perl5.changes/2009/08/msg24859.html
In some ways it is kind of useless if changes merged from outside
repos always list the author as both the author and the committer.
This seems to be a problem for merges in general, but especially when they
are fast-forwarded without even creating a merge commit, as the original
commit will not be changed to preserve the SHA1. An easy solution would
be to always cherry-pick from external branches.
pod/perlrepository.pod currently says (about merging from github):
| If you approve of a specific commit, you can cherry pick it:
|
| % git cherry-pick 3adac458cb1c1d41af47fc66e67b49c8dec2323f
|
| Or you could just merge the whole branch if you like it all:
|
| % git merge dandv/blead
Should this be changed to discourage merges and request that changes
from outside branches should always be cherry-picked?
Cheers,
-Jan
Thread Next