develooper Front page | perl.perl5.porters | Postings from July 2010

Re: [perl #76402] [PATCH] Locale::Maketext One Sided Lexicons

Thread Previous | Thread Next
From:
Todd Rinaldo
Date:
July 22, 2010 11:32
Subject:
Re: [perl #76402] [PATCH] Locale::Maketext One Sided Lexicons
Message ID:
6C1B6910-1D04-4254-B3F4-3282C5385EE0@cpanel.net

On Jul 15, 2010, at 12:54 PM, Jesse Vincent wrote:

> On Thu, Jul 15, 2010 at 10:37:19AM -0500, Todd Rinaldo wrote:
>> 
>> On Jul 8, 2010, at 8:57 AM, Jesse Vincent wrote:
>> 
>> Jesse,
>> 
>> Onesided-ness is a complementary feature to _AUTO, not a replacement. 
>> 
>> When you have code that uses _AUTO, Locale fall back happens. The only way to prevent this is to inject a key with an equivalent value to prevent fallback. Sometimes unexpected defaulting might happen. This isn't something you'd use all the time, but in the cases where you do, onesided-ness is more "fat-finger safe" than duping key and value pairs.
> 
> 
> This just feels like feature creep that might better belong in a subclass.

The only way to subclass it is a monolithic copy/paste. I don't see that it being added hurts anything existing. Even if it is feature creep, what's the down side of that? Honestly I see it as a part of L:M or something else that has to re-implement or duplicate the whole method. That would be a code fork, which I'm trying to avoid here.

> And for that matter, why not add an option that works like _AUTO rather
> than all the duplicated entries?


The goal was to avoid polluting the lexicon namespace with another special variable. Since each lexicon is it's own package, it made more sense to put it outside the lexicon. If that's really what's causing you to hesitate, I have no issues providing an amended patch which uses the lexicon instead to look for the _ONE_SIDED flag.

Todd
Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About