develooper Front page | perl.perl5.porters | Postings from July 2010

Re: [PATCH] Configure probe for static inline

Thread Previous | Thread Next
Nicholas Clark
July 9, 2010 03:31
Re: [PATCH] Configure probe for static inline
Message ID:
On Thu, Jul 08, 2010 at 02:14:34PM +0200, H.Merijn Brand wrote:
> On Tue, 6 Jul 2010 12:48:56 -0400 (EDT), Andy Dougherty
> <> wrote:
> > Here is a proposed patch to enable Configure to probe for C99-style 
> > 'static inline'.  (That is, functions may be inlined, but will not be 
> > externally visible.)  The initial idea is that some common code in messy 
> > macros inside headers might be simplified using inline functions.  If the 
> > compiler does not support 'static inline', then a plain 'static' is used 
> > instead, along with the consequent implications of a function call.  In 
> > either case, you simply use  PERL_STATIC_INLINE.

Thanks for working on this.
This will enable a lot of cleanup of existing messy macros.

> I suggest just committing this and see how smokes react

I'd suggest this too. *I* don't know how to take a metaconfig patch and use
it to rebuild Configure and config_h.SH, so I'm doubtful that many other
people will either.

I suspect it will only get realistic testing if it's in blead, and smokers
(and humans) try it as a side effect of building blead for other reasons.

However, I'm not sure how many people have access to non-gcc, and particularly
non-gcc non x86 (or x86_64) platforms, to see how those compilers' code
generators react to changing from macros to inline functions. So it's going
to be tricky to really get good confidence on what the impact of changes are,
outside VAX 2.0*

Nicholas Clark

*  The thing that all the world is. [x86, gcc, ELF,, these days.**]
** Which may change, if portable devices usurp laptops, and battery life
   favours ARMs.

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About