develooper Front page | perl.perl5.porters | Postings from June 2010

Re: [perl #75436] Segfault with lexical $_ and reverse() since e1f795dc

Thread Previous
From:
Rafael Garcia-Suarez
Date:
June 1, 2010 14:34
Subject:
Re: [perl #75436] Segfault with lexical $_ and reverse() since e1f795dc
Message ID:
AANLkTimEfCZZWXxjze7qDVOC4A3Qg8_61zhwobmOMne9@mail.gmail.com
On 31 May 2010 01:11, Vincent Pit <perl@profvince.com> wrote:
> I've attached two patches that fix the issue. Both fetch the name sv
> associated with $_ from the current run-time pad instead of the comppad.
> The former inlines all the new required code in pp_reverse, while the
> second one introduces a new find_rundefsv() function that abstracts this
> logic. Since I suspect that the UNDERBAR macro is also wrong (it's
> deemed to be called at run-time), my preferred solution would be to
> apply the second patch, change UNDERBAR to use find_rundefsv(), and
> deprecate find_rundefsvoffset() as I don't think it's really useful in
> the end.

I agree with the analysis and the plan.

I don't think that much code uses find_rundefsvoffset. Even List::Util
does not, actually.

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About