Front page | perl.perl5.porters |
Postings from May 2010
On Wed, May 26, 2010 at 14:41, Nicholas Clark <nick@ccl4.org> wrote: > On Wed, May 26, 2010 at 02:25:23PM -0400, Jerry D. Hedden wrote: >> On Tue, May 25, 2010 at 17:38, Nicholas Clark <nick@ccl4.org> wrote: >> > Also, it seems that this commit: >> > >> > commit bb1bc619ea68d9703fbd3fe5bc65ae000f90151f >> > Author: Father Chrysostomos (via RT) <perlbug-followup@perl.org> >> > Date: Sun Jan 17 14:32:24 2010 -0800 >> > >> > Deref ops ignore get-magic when SvROK(sv) >> > >> > This is just like bug 68192, except in this case it?s a different set >> > of operators that have had this problem for much longer. >> > >> > causes the TODO test at the end of dist/threads-shared/t/object.t to start >> > passing: >> > >> > ok 24 - Main: Object ID 1 >> > ok 25 - Thread: Object ID 1 >> > ok 26 - Thread: Changed object ID 10 >> > ok 27 - Thread: New object ID 2 >> > ok 28 - Main: New object ID 2 # TODO - should be 2 >> >> Interesting. Since the change that fixed this test did not involve >> shared.xs code should this test be moved to t/op/??? >> Or should I just make it conditionally TODO based on perl version? > > I don't know. I had assumed make it conditionally TODO, but I don't know *why* > it starts passing. (Other than the description implies that magic will now be > called where previously it incorrectly wasn't, and shared scalars > implemented via magic) I'll make it conditionally TODO. Patch to blead forthcoming.