develooper Front page | perl.perl5.porters | Postings from May 2010

Re: 5.12: inplace sort <*> segfault (gcc 4.5.0 bug?)

Thread Previous | Thread Next
From:
Alex Hunsaker
Date:
May 11, 2010 08:36
Subject:
Re: 5.12: inplace sort <*> segfault (gcc 4.5.0 bug?)
Message ID:
AANLkTimUA0vY90qnrhqBE8tqDouRz2y4bcyyjxtxuiMH@mail.gmail.com
On Tue, May 11, 2010 at 09:31, Eric Brine <ikegami@adaelis.com> wrote:
> On Tue, May 11, 2010 at 10:22 AM, <hv@crypt.org> wrote:
>>
>> Now submitted as <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44081>.
>
> Did you nonnull the wrong parameter?

Looks like it from the test:

static OP* test(void* v, OP* o, OP *o2)
		__attribute__((nonnull(2)));

Ok o2 is marked nonull so it makes sense passing in NULL segfaults.

S_is_inplace_av is defined as:
STATIC OP*      S_is_inplace_av(pTHX_ OP* o, OP* oright)
                        __attribute__nonnull__(pTHX_1);

And If I read the macros right that should be OP* o is marked nonnull
while oright is not marked nonnull.  Granted I may have misunderstood
the expansion....

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About