Re: 5.12.1 prep

Front page | perl.perl5.porters | Postings from May 2010

Thread Previous | Thread Next

From:

karl williamson

Date:

May 6, 2010 21:28

Subject:

Re: 5.12.1 prep

Message ID:

4BE396EF.8050603@khwilliamson.com

Jesse Vincent wrote:
> I'm planning on cutting an RC0 on Friday. What do folks want merged that
> hasn't yet been merged down?
> 
> -jesse
> 

I'd like to lobby for some patches to go into 5.12.1.

First, I'm surprised that no one mentioned
  7dcb3b25fc4113f0eeb68d0d3c47ccedd5ff3f2a
which fixes [perl #72998] regex looping.  I thought a dot release would 
include all available sane fixes for perl crashing or hanging.

Second, I don't understand the reluctance to include all doc patches 
that are applicable.  Clearly, patches such as for 5.13 API changes 
shouldn't go in; but it seems to me that anything else that is an 
improvement over previous documentation should go in, such as adding the 
=encoding lines that Ævar submitted.

I just looked at a diff from the 5.12.0 pod directory and the blead one. 
  I see a number of improvements, and corrections.  It seems like false 
economy to be stingy with putting documentation improvements in a dot 
release.  I don't see any risk that needs to be weighed versus the 
benefit of better informed and hence happier users.

I myself have made a number of changes to clarify things in the areas I 
know about.  For example, the changes in perlfunc that document the case 
changing functions under the new feature unicode_strings were mistakenly 
removed for 5.12.0.  These functions aren't adequately documented 
anywhere unless
3980dc9c1cbee6225cd296829ee61b2abbd851c8
is put in.  The behavior of [[:punct::]] vs \p{punct} has never been 
fully explained until the patch I submitted yesterday which has not been 
applied is put in.

There were relics left over from 5.11 that were backed out before 5.12 
shipped, but the documentation did not get updated, nor will it unless
ea4495057aaed60cdb8c514940b386ea41efc090
is put in.

I added discussion of Unicode security issues for \d and \w matching in 
6b83a1635615fc637befef006ba0c66679d101d8

The pre-existing documentation of \c has been inconsistent, and wrong in 
places.  I cleaned that up with several commits:
2c09a866c8998f757d628460ed585e1cb8011792
5691ca5ffd4d6a13697bf93428d59bef37aea48a
4948b50f6c618b295b44b4f36de1f0f157db591b

And I could go on.  I've made quite a few changes to the documentation 
on Unicode and regex handling, besides just these few commits; all of 
it, I think, should go in 5.12.1.

I can't speak about changes that others have made in particular, but it 
seems to me that the impetus should be that doc patches should go in a 
dot release unless otherwise contraindicated.  That is the opposite of 
code patches; which should have a very good reason to be considered for 
a dot release.

Thread Previous | Thread Next