develooper Front page | perl.perl5.porters | Postings from May 2010

Re: [PATCH] shift; optimization

Thread Previous | Thread Next
From:
Ruslan Zakirov
Date:
May 3, 2010 07:48
Subject:
Re: [PATCH] shift; optimization
Message ID:
q2x589c94401005030748gcced438ew283ea2b867ad06a1@mail.gmail.com
Hello,

Updated version:

* C89 fix
* updates for a test that uses B::Concise

While testing a simple benchmark script I noticed that threaded
version is 25% faster. I suspect that the code may be is not thread
safe, however don't know anything about perl threads.

On Fri, Apr 16, 2010 at 2:22 PM, Vincent Pit <perl@profvince.com> wrote:
>
>> Thanks for this patch. At first glance it looks correct.
>
> Except for a nit, actually : you need to keep the declaration of argop at
> the beginning of the block. C89 doesn't allow mixed declaration and code.
>
> Vincent.
>
>



-- 
Best regards, Ruslan.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About