develooper Front page | perl.perl5.porters | Postings from April 2010

[PATCH RFC] maint policy change: cherry-picked commits should have --signoff

Thread Next
From:
avar
Date:
April 26, 2010 13:17
Subject:
[PATCH RFC] maint policy change: cherry-picked commits should have --signoff
Message ID:
1272312972-8633-1-git-send-email-avar@cpan.org
From: Ævar Arnfjörð Bjarmason <avar@cpan.org>

It's a lot easier to follow who agreed to integrating a given commit
to maint when it's part of the Git history. Having it in Git doesn't
replace the mailing list discussion, it compliments it.

Signed-off-by: Ævar Arnfjörð Bjarmason <avar@cpan.org>
---

This is a patch RFC. Maybe the commiters don't like this idea, but I
think it would make it easier to monitor maint integrations.

 pod/perlpolicy.pod |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/pod/perlpolicy.pod b/pod/perlpolicy.pod
index 380a177..4a0c68d 100644
--- a/pod/perlpolicy.pod
+++ b/pod/perlpolicy.pod
@@ -83,6 +83,18 @@ a specific commit along with a rationale for doing so and at least two
 other committers respond to the list giving their assent. (This policy
 applies to current and former pumpkings, as well as other committers.)
 
+A change that is cherry-picked to maint should have a signed-off-by
+entry for each commiter that agrees to its integration. This can be
+done as:
+
+    # cherry-pick a commit
+    git checkout maint-5.12
+    git cherry-pick COMMIT
+
+    # Edit the commit in an editor. Add any missing Signed-off-by
+    # lines manually for missing commiters that agreed
+    git commit --signoff --amend
+
 =head1 CONTRIBUTED MODULES
 
 
-- 
1.7.1.rc1


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About