Re: [perl #72108] gv_e?fullname[34] improvement

On Fri, Jan 15, 2010 at 08:46:43AM -0800, Nicholas Clark wrote:
> # New Ticket Created by  Nicholas Clark 
> # Please include the string:  [perl #72108]
> # in the subject line of all future correspondence about this issue. 
> # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=72108 >
> 
> 
> It seems that a fairly common pairing in the perl source is:
> 
> 	    tmpsv = newSV(0);
> 	    gv_efullname3(tmpsv, gv, NULL);
> 
> or generating a new mortal and passing it in.
> 
> All functions in the gv_e?fullname{,3,4} family are ultimately wrappers
> around gv_fullname4(), which currently returns void, and takes a not NULL
> first argument.
> 
> It would probably reduce the core's code size to change it to return SV *,
> and generate a new SV (possibly mortal) if the first argument is NULL.

Instead of overloading the interface, wouldn't it be better to add
extra functions that create the GV, and then calls gv_e?fullname4().

The new functions could be marked with the R flag to make sure the
returned new GV isn't ignored.

Tony

• [perl #72108] gv_e?fullname[34] improvement by Nicholas Clark
• Re: [perl #72108] gv_e?fullname[34] improvement by Tony Cook
• Re: [perl #72108] gv_e?fullname[34] improvement by Nicholas Clark
• Re: [perl #72108] gv_e?fullname[34] improvement by Tony Cook