develooper Front page | perl.perl5.porters | Postings from December 2009

Re: [perl #71076] [PATCH] sort with active sub (5.10 regression)

Thread Next
From:
Father Chrysostomos
Date:
December 7, 2009 02:22
Subject:
Re: [perl #71076] [PATCH] sort with active sub (5.10 regression)
Message ID:
82923264-8BE8-4A06-B2A9-A14C34E43469@cpan.org
One of the tests in sort.t causes a bus error (or sometimes ‘Undefined  
subroutine called’) if run multiple times:

for(1..2)

{
     my $failed = 0;

     sub rec {
	my $n = shift;
	if (!defined($n)) {  # No arg means we're being called by sort()
	    return 1;
	}
	if ($n<5) { rec($n+1); }
	else { () = sort rec 1,2; }

	$failed = 1 if !defined $n;
     }

     rec(1);
}

This is because sort decreases the refcount of an active sub used as a  
comparison routine.

Ironically enough, this test was added by the very change that broke  
it (25953/9850bf2).

The attached patch fixes this and also fixes a refcnt test that wasn’t  
testing was it purported to be testing, which almost lead me to  
introduce a new bug while fixing this one.

Use of uninitialized value $category in concatenation (.) or string  
at /usr/local/bin/perlbug5.11.2 line 645.
Use of uninitialized value $severity in concatenation (.) or string  
at /usr/local/bin/perlbug5.11.2 line 645.
---
Flags:
    category=core
    severity=low
---
Site configuration information for perl 5.11.2:

Configured by sprout at Thu Nov 26 19:53:28 PST 2009.

Summary of my perl5 (revision 5 version 11 subversion 2 patch  
v5.11.2-81-g162177c) configuration:
  Snapshot of: c2123ae380a372d506d1b6938667bd785fd8728b
  Platform:
    osname=darwin, osvers=10.0.0, archname=darwin-2level
    uname='darwin pint.local 10.0.0 darwin kernel version 10.0.0: fri  
jul 31 22:47:34 pdt 2009; root:xnu-1456.1.25~1release_i386 i386 '
    config_args='-de -Dusedevel'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-common -DPERL_DARWIN -no-cpp-precomp -fno- 
strict-aliasing -pipe -fstack-protector -I/usr/local/include',
    optimize='-O3',
    cppflags='-no-cpp-precomp -fno-common -DPERL_DARWIN -no-cpp- 
precomp -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/ 
include'
    ccversion='', gccversion='4.2.1 (Apple Inc. build 5646)',  
gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',  
lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack- 
protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib
    libs=-ldbm -ldl -lm -lutil -lc
    perllibs=-ldl -lm -lutil -lc
    libc=/usr/lib/libc.dylib, so=dylib, useshrplib=false,  
libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/ 
usr/local/lib -fstack-protector'

Locally applied patches:


---
@INC for perl 5.11.2:
    /usr/local/lib/perl5/site_perl/5.11.2/darwin-2level
    /usr/local/lib/perl5/site_perl/5.11.2
    /usr/local/lib/perl5/5.11.2/darwin-2level
    /usr/local/lib/perl5/5.11.2
    /usr/local/lib/perl5/site_perl
    .

---
Environment for perl 5.11.2:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/sprout
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin:/ 
usr/local/bin
    PERL_BADLANG (unset)
    SHELL=/bin/bash

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About