develooper Front page | perl.perl5.porters | Postings from December 2009

Re: fix for 7baa4690 breakage of threaded builds

Thread Previous
From:
jesse
Date:
December 6, 2009 19:45
Subject:
Re: fix for 7baa4690 breakage of threaded builds
Message ID:
20091207034456.GU21237@bestpractical.com



On Mon, Dec 07, 2009 at 01:39:10PM +1100, Tony Cook wrote:
> Changed to pass the thread context around.
> 
> Attacehd.

Thanks. Applied.
> 
> Tony

> diff --git a/sv.c b/sv.c
> index 3151679..7527856 100644
> --- a/sv.c
> +++ b/sv.c
> @@ -9168,7 +9168,7 @@ Perl_sv_vsetpvfn(pTHX_ SV *const sv, const char *const pat, const STRLEN patlen,
>   */
>  #define WARN_MISSING WARN_UNINITIALIZED /* Not sure we want a new category */
>  STATIC SV*
> -S_vcatpvfn_missing_argument(pTHX_) {
> +S_vcatpvfn_missing_argument(pTHX) {
>      if (ckWARN(WARN_MISSING)) {
>  	Perl_warner(aTHX_ packWARN(WARN_MISSING), "Missing argument in %s",
>  		PL_op ? OP_DESC(PL_op) : "sv_vcatpvfn()");
> @@ -9542,10 +9542,10 @@ Perl_sv_vcatpvfn(pTHX_ SV *const sv, const char *const pat, const STRLEN patlen,
>  		    vecsv = va_arg(*args, SV*);
>  		else if (evix) {
>  		    vecsv = (evix > 0 && evix <= svmax)
> -			? svargs[evix-1] : S_vcatpvfn_missing_argument();
> +			? svargs[evix-1] : S_vcatpvfn_missing_argument(aTHX);
>  		} else {
>  		    vecsv = svix < svmax
> -			? svargs[svix++] : S_vcatpvfn_missing_argument();
> +			? svargs[svix++] : S_vcatpvfn_missing_argument(aTHX);
>  		}
>  		dotstr = SvPV_const(vecsv, dotstrlen);
>  		/* Keep the DO_UTF8 test *after* the SvPV call, else things go
> @@ -9693,10 +9693,10 @@ Perl_sv_vcatpvfn(pTHX_ SV *const sv, const char *const pat, const STRLEN patlen,
>  	    if (efix) {
>  		const I32 i = efix-1;
>  		argsv = (i >= 0 && i < svmax)
> -		    ? svargs[i] : S_vcatpvfn_missing_argument();
> +		    ? svargs[i] : S_vcatpvfn_missing_argument(aTHX);
>  	    } else {
>  		argsv = (svix >= 0 && svix < svmax)
> -		    ? svargs[svix++] : S_vcatpvfn_missing_argument();
> +		    ? svargs[svix++] : S_vcatpvfn_missing_argument(aTHX);
>  	    }
>  	}
>  


-- 

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About